Re: [PATCH 13/19] arm64: dts: qcom: x1e80100: Fix ADSP memory base and length

From: Johan Hovold
Date: Fri Dec 06 2024 - 10:49:50 EST


On Fri, Dec 06, 2024 at 04:32:37PM +0100, Krzysztof Kozlowski wrote:
> The address space in ADSP PAS (Peripheral Authentication Service)
> remoteproc node should point to the QDSP PUB address space
> (QDSP6...SS_PUB): 0x0680_0000 with length of 0x10000.
>
> 0x3000_0000, value used so far, is the main region of CDSP. Downstream
> DTS uses 0x0300_0000, which is oddly similar to 0x3000_0000, yet quite
> different and points to unused area.

This looks like a copy-paste error since there is no downstream DTS for
x1e80100.

And this paragraph is about the CDSP so probably does not belong in the
commit message of the ADSP patches (e.g. sm8650).

> Correct the base address and length, which also moves the node to
> different place to keep things sorted by unit address. The diff looks
> big, but only the unit address and "reg" property were changed. This
> should have no functional impact on Linux users, because PAS loader does
> not use this address space at all.

Johan