Re: [PATCH PATCH RFT 15/19] arm64: dts: qcom: sm6350: Fix ADSP memory length

From: Luca Weiss
Date: Fri Dec 06 2024 - 10:55:55 EST


On Fri Dec 6, 2024 at 4:32 PM CET, Krzysztof Kozlowski wrote:
> The address space in ADSP (Peripheral Authentication Service) remoteproc
> node should point to the QDSP PUB address space (QDSP6...SS_PUB) which
> has a length of 0x10000.
>
> This should have no functional impact on Linux users, because PAS loader
> does not use this address space at all.

I can't verify this information, but with this change ADSP is still
starting up as expected:

Tested-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>

>
> Fixes: efc33c969f23 ("arm64: dts: qcom: sm6350: Add ADSP nodes")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> index 8d697280249fefcc62ab0848e949b5509deb32a6..3df506c2745ea27f956ef7d7a4b5fbaf6285c428 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> @@ -1283,7 +1283,7 @@ tcsr_mutex: hwlock@1f40000 {
>
> adsp: remoteproc@3000000 {
> compatible = "qcom,sm6350-adsp-pas";
> - reg = <0 0x03000000 0 0x100>;
> + reg = <0x0 0x03000000 0x0 0x10000>;
>
> interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
> <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,