Re: [PATCH v7 4/5] arm64: dts: qcom: sc7280: Add support for camss

[Vikram Sharma]

On 12/5/2024 9:58 PM, Konrad Dybcio wrote:
> On 4.12.2024 11:00 AM, Vikram Sharma wrote:
> > Add changes to support the camera subsystem on the SC7280.
> >
> > Signed-off-by: Suresh Vankadara <quic_svankada@xxxxxxxxxxx>
> > Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@xxxxxxxxxxx>
> > Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx>
> > ---
> [...]
>
> (isp@ as mentioned)
Hi Konrad,

Thanks for your review and comments.
I have posted V8 addressing these comments.

Best Regards,
Vikram

> > +			interconnects = <&gem_noc  MASTER_APPSS_PROC 0 &cnoc2 SLAVE_CAMERA_CFG 0>,
> QCOM_ICC_TAG_ACTIVE_ONLY
>
> > +					<&mmss_noc MASTER_CAMNOC_HF  0 &mc_virt SLAVE_EBI1     0>;
> QCOM_ICC_TAG_ALWAYS
>
> > +			interconnect-names = "ahb", "hf_0";
> > +
> > +			iommus = <&apps_smmu 0x800 0x4e0>;
> > +
> > +			power-domains = <&camcc CAM_CC_IFE_0_GDSC>,
> > +					<&camcc CAM_CC_IFE_1_GDSC>,
> > +					<&camcc CAM_CC_IFE_2_GDSC>,
> > +					<&camcc CAM_CC_TITAN_TOP_GDSC>;
> > +			power-domain-names = "ife0", "ife1", "ife2", "top";
> vertical list, please
>
> Konrad