Re: [PATCH v4 3/3] media: dt-bindings: qcom-venus: Deprecate video-decoder and video-encoder where applicable

From: Bryan O'Donoghue
Date: Fri Dec 06 2024 - 16:26:56 EST


On 06/12/2024 10:03, Dikshita Agarwal wrote:
On 11/28/2024 9:51 PM, Bryan O'Donoghue wrote:
For the list of yaml files here the video-decoder and video-encoder nodes
provide nothing more than configuration input for the driver. These entries
do not in fact impart hardware specific data and should be deprecated.

Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@xxxxxxxxxx>
Signed-off-by: Bryan O'Donoghue<bryan.odonoghue@xxxxxxxxxx>
---
.../devicetree/bindings/media/qcom,msm8916-venus.yaml | 12 ++----------
.../devicetree/bindings/media/qcom,sc7180-venus.yaml | 12 ++----------
.../devicetree/bindings/media/qcom,sc7280-venus.yaml | 12 ++----------
.../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 12 ++----------
.../devicetree/bindings/media/qcom,sm8250-venus.yaml | 12 ++----------
5 files changed, 10 insertions(+), 50 deletions(-)

A general query, this change is not done for 8996-venus, sdm660-venus and
sdm845-venus, was that intentional? may be because these are not active
SOCs in upstream?

No per the cover letter, those SoCs have power-domains and clocks inside of them, so the dtsi entries actually does relate to a hardware description in that case.

---
bod