Re: [PATCH v1] tools/hv: reduce resouce usage in hv_get_dns_info helper

[Wei Liu]

On Mon, Dec 02, 2024 at 01:04:10PM +0100, Olaf Hering wrote:
> Remove the usage of cat. Replace the shell process with awk with 'exec'.
> Also use a generic shell because no bash specific features will be used.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

The resource saving is not a lot, but nonetheless:

Acked-by: Wei Liu <wei.liu@xxxxxxxxxx>

> ---
>  tools/hv/hv_get_dns_info.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/hv/hv_get_dns_info.sh b/tools/hv/hv_get_dns_info.sh
> index 058c17b46ffc..268521234d4b 100755
> --- a/tools/hv/hv_get_dns_info.sh
> +++ b/tools/hv/hv_get_dns_info.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>  
>  # This example script parses /etc/resolv.conf to retrive DNS information.
>  # In the interest of keeping the KVP daemon code free of distro specific
> @@ -10,4 +10,4 @@
>  # this script can be based on the Network Manager APIs for retrieving DNS
>  # entries.
>  
> -cat /etc/resolv.conf 2>/dev/null | awk '/^nameserver/ { print $2 }'
> +exec awk '/^nameserver/ { print $2 }' /etc/resolv.conf 2>/dev/null
>