Re: [PATCH v2 3/5] arm64: dts: exynos: gs101: allow stable USB phy Vbus detection

[Peter Griffin]

On Tue, 3 Dec 2024 at 12:40, André Draszik <andre.draszik@xxxxxxxxxx> wrote:
>
> For the DWC3 core to reliably detect the connected phy's Vbus state, we
> need to disable phy suspend.
>
> Add
>     snps,dis_u2_susphy_quirk
>     snps,dis_u3_susphy_quirk
> to do that.
>
> While at it, also add
>     snps,has-lpm-erratum
> as this is set downstream which implies that the core was configured
> with LPM Erratum. We should do the same here.
>
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
>
> ---

Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
Tested-by: Peter Griffin <peter.griffin@xxxxxxxxxx>

Notes on testing:

Tested with a Pixel 6 device with 2 different USB hubs and also
directly into the laptop, plugging and unplugging from both ends of
the cable. With this set of snps quirks disconnect/reconnect always
seems to be robustly detected.