Re: [PATCH v2 1/2] dt-bindings: iio: light: Add APDS9160 binding

[Jonathan Cameron]

On Fri, 6 Dec 2024 15:03:17 -0500
Mikael Gonella-Bolduc <mgonellabolduc@xxxxxxxxxxxx> wrote:

> Hi Conor,
> 
> See my comments inline.
> 
> Thank you,
> Mikael
> 
> On Fri, Dec 06, 2024 at 04:33:36PM +0000, Conor Dooley wrote:
> > On Fri, Dec 06, 2024 at 11:09:56AM -0500, Mikael Gonella-Bolduc via B4 Relay wrote:  
> > > From: Mikael Gonella-Bolduc <mgonellabolduc@xxxxxxxxxxxx>
> > > 
> > > Add device tree bindings for APDS9160 driver  
> > 
> > Bindings are for hardware, not for drivers.
> >   
> 
> Indeed, should I change the commit message to remove the "driver" part?
Yes.
> 
> > > 
> > > Signed-off-by: Mikael Gonella-Bolduc <mgonellabolduc@xxxxxxxxxxxx>
> > > ---
> > >  .../bindings/iio/light/brcm,apds9160.yaml          | 51 ++++++++++++++++++++++
> > >  1 file changed, 51 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..525fba52f156df3b78e24d7d0d445fe9d882eaa7
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
> > > @@ -0,0 +1,51 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/light/brcm,apds9160.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Broadcom Combined Proximity & Ambient light sensor
> > > +
> > > +maintainers:
> > > +  - Mikael Gonella-Bolduc <m.gonella.bolduc@xxxxxxxxx>  
> > 
> > How come this differs from your author email?
> >   
> 
> The author email is my work email, this one is my personal email.
> The first one might change while the other one will not.
> Is it required to have the same email here?
I don' think there are firm rules on this, but there are processes in place
for changing email via .mailmap and where relevant patches updating
to a new email address.  A note in the commit message would be appropriate though.

Jonathan

>