Re: [PATCH 29/31] PM / devfreq: rockchip-dfi: Switch to use hrtimer_setup()

[Chanwoo Choi]

Hi,

Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Thanks,

On Mon, Oct 28, 2024 at 4:42 PM Nam Cao <namcao@xxxxxxxxxxxxx> wrote:
>
> There is a newly introduced hrtimer_setup() which will replace
> hrtimer_init(). This new function is similar to the old one, except that it
> also sanity-checks and initializes the timer's callback function.
>
> Switch to use this new function.
>
> Patch was created by using Coccinelle.
>
> Signed-off-by: Nam Cao <namcao@xxxxxxxxxxxxx>
> ---
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
>  drivers/devfreq/event/rockchip-dfi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index e2a1e4463b6f..0470d7c175f4 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -642,8 +642,7 @@ static int rockchip_ddr_perf_init(struct rockchip_dfi *dfi)
>         if (ret)
>                 return ret;
>
> -       hrtimer_init(&dfi->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> -       dfi->timer.function = rockchip_dfi_timer;
> +       hrtimer_setup(&dfi->timer, rockchip_dfi_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
>
>         switch (dfi->ddr_type) {
>         case ROCKCHIP_DDRTYPE_LPDDR2:
> --
> 2.39.5
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics