Re: [PATCH] iio: adc: ti-ads1119: fix sample size in scan struct for triggered buffer

From: Jonathan Cameron
Date: Sun Dec 08 2024 - 12:00:00 EST


On Mon, 2 Dec 2024 20:46:22 +0100
Francesco Dolcini <francesco@xxxxxxxxxx> wrote:

> On Mon, Dec 02, 2024 at 08:18:44PM +0100, Javier Carrasco wrote:
> > This device returns signed, 16-bit samples as stated in its datasheet
> > (see 8.5.2 Data Format). That is in line with the scan_type definition
> > for the IIO_VOLTAGE channel, but 'unsigned int' is being used to read
> > and push the data to userspace.
> >
> > Given that the size of that type depends on the architecture (at least
> > 2 bytes to store values up to 65535, but its actual size is often 4
> > bytes), use the 's16' type to provide the same structure in all cases.
> >
> > Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
>
> Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
>
> Thanks,
> Francesco
>

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan