Re: [PATCH v2] iio: kx022a: document new chip_info structure members

From: Mehdi Djait
Date: Sun Dec 08 2024 - 12:34:29 EST


Hi Jonathan and Matti,

thank you Matti for the patch.

On Sat, Dec 07, 2024 at 06:02:01PM +0000, Jonathan Cameron wrote:
> On Fri, 6 Dec 2024 11:26:42 +0200
> Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
>
> > The kx022a driver supports a few different HW variants. A chip-info
> > structure is used to describe sensor specific details. Support for
> > sensors with different measurement g-ranges was added recently,
> > introducing sensor specific scale arrays.
> >
> > The members of the chip-info structure have been documented using
> > kerneldoc. The newly added members omitted the documentation. It is nice
> > to have all the entries documented for the sake of the consistency.
> > Furthermore, the scale table format may not be self explatonary, nor how
> > the amount of scales is informed.
> >
> > Add documentation to scale table entries to maintain consistency and to
> > make it more obvious how the scales should be represented.
> >

Reviewed-by: Mehdi Djait <mehdi.djait@xxxxxxxxxxxxxxx>

> > Suggested-by: Mehdi Djait <mehdi.djait@xxxxxxxxxxxxxxx>
> > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> Applied to the togreg branch of iio.git. Initially pushed out as testing.
>
> Mehdi, if you want to give a tag (or more feedback) I am happy to rebase
> for a few days.

the kernel-doc looks good to me.
thank you Jonathan.

--
Kind Regards
Mehdi Djait