Re: [PATCH v8 8.1/9] x86/virt/tdx: Reduce TDMR's reserved areas by using CMRs to find memory holes

[Huang, Kai]

On Thu, 2024-12-05 at 10:10 -0800, Hansen, Dave wrote:
> On 12/5/24 04:40, Kai Huang wrote:
> > A TDX module initialization failure was reported on a Emerald Rapids
> > platform [*]:
> > 
> >   virt/tdx: initialization failed: TDMR [0x0, 0x80000000): reserved areas exhausted.
> >   virt/tdx: module initialization failed (-28)
> 
> There's a *LOT* of changelog here, but I'm not sure how much of it is
> actually relevant to the problem at hand. I also think it's wrong to to
> present the problem as one of being too fine-grained.
> 
> Could you please rework the changelog and the comments to make this more
> succinct?

Hi Dave,

I sent out the "PATCH v8 8.2/9".  I trimmed down the changelog to keep it
succinct.  I also trimmed the comments around the is_cmr_sub_region() in
build_tdx_memory() and the tdmrs_populate_rsvd_areas_all() in construct_tdmrs()
to explain the code change.

Appreciate your review.