Re: [PATCH v3 1/3] dt-bindings: firmware: add samsung,exynos-acpm-ipc bindings

From: Tudor Ambarus
Date: Mon Dec 09 2024 - 03:19:46 EST




On 12/9/24 8:03 AM, Krzysztof Kozlowski wrote:
>> + initdata-base:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + Base address of the configuration data in the shared memory.
> If you really need this, then it should be rather encoded as part of
> shemm phandle (phandle-array with describing items, just like syscon
> phandles are done).
>
> But OTOH, I don't see why this is needed at all so far - compatible
> defines it.

Indeed, I shall move it to compatible. If firmware ever changes, and
uses a different offset to the configuration data, then I can introduce
a new compatible.

I agree with all the other comments as well, will address them in v4.

Thanks!
ta