Re: [PATCH v3 3/3] arm64: dts: qcom: qcs615-ride: Enable UFS node

[Xin Liu]

在 2024/12/2 22:48, Manivannan Sadhasivam 写道:
> On Fri, Nov 22, 2024 at 02:44:28PM +0800, Xin Liu wrote:
> > From: Sayali Lokhande <quic_sayalil@xxxxxxxxxxx>
> >
> > Enable UFS on the Qualcomm QCS615 Ride platform.
> >
> > Signed-off-by: Sayali Lokhande <quic_sayalil@xxxxxxxxxxx>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Xin Liu <quic_liuxin@xxxxxxxxxxx>
> > Signed-off-by: Xin Liu <quic_liuxin@xxxxxxxxxxx>
>
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
>
> One question below.
>
> > ---
> >   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 16 ++++++++++++++++
> >   1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > index ee6cab3924a6..79634646350b 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > @@ -214,6 +214,22 @@ &uart0 {
> >   	status = "okay";
> >   };
> >   
> > +&ufs_mem_hc {
>
> No 'reset-gpios' to reset the UFS device?
I will check it, and fix it next version.
> - Mani