Re: [PATCH v2 14/16] cpufreq/amd-pstate: Drop ret variable from amd_pstate_set_energy_pref_index()
From: Gautham R. Shenoy
Date: Mon Dec 09 2024 - 04:25:53 EST
On Sun, Dec 08, 2024 at 12:30:29AM -0600, Mario Limonciello wrote:
> The ret variable is not necessary.
>
> Reviewed-and-tested-by: Dhananjay Ugwekar <dhananjay.ugwekar@xxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx>
--
Thanks and Regards
gautham.
> ---
> drivers/cpufreq/amd-pstate.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 2178931fbf87b..5869bcd287e87 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -318,13 +318,11 @@ static int shmem_set_epp(struct amd_cpudata *cpudata, u32 epp)
> static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata,
> int pref_index)
> {
> - int epp = -EINVAL;
> - int ret;
> + int epp;
>
> if (!pref_index)
> epp = cpudata->epp_default;
> -
> - if (epp == -EINVAL)
> + else
> epp = epp_values[pref_index];
>
> if (epp > 0 && cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) {
> @@ -340,9 +338,7 @@ static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata,
> cpudata->boost_state);
> }
>
> - ret = amd_pstate_set_epp(cpudata, epp);
> -
> - return ret;
> + return amd_pstate_set_epp(cpudata, epp);
> }
>
> static inline int msr_cppc_enable(bool enable)
> --
> 2.43.0
>