Re: [net-next PATCH v5 2/6] octeontx2-af: CN20k basic mbox operations and structures

[Sai Krishna Gajula]

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Sunday, December 8, 2024 8:11 AM
> To: Sai Krishna Gajula <saikrishnag@xxxxxxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Sunil Kovvuri Goutham
> <sgoutham@xxxxxxxxxxx>; Geethasowjanya Akula <gakula@xxxxxxxxxxx>;
> Linu Cherian <lcherian@xxxxxxxxxxx>; Jerin Jacob <jerinj@xxxxxxxxxxx>;
> Hariprasad Kelam <hkelam@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta
> <sbhatta@xxxxxxxxxxx>; andrew+netdev@xxxxxxx; kalesh-
> anakkur.purayil@xxxxxxxxxxxx
> Subject: Re: [net-next PATCH v5 2/6] octeontx2-af: CN20k basic
> mbox operations and structures
> 
> On Wed, 4 Dec 2024 19: 38: 17 +0530 Sai Krishna wrote: > - ret =
> request_irq(pci_irq_vector(rvu->pdev, RVU_AF_INT_VEC_MBOX), > -
> rvu_mbox_pf_intr_handler, 0, > - &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
> NAME_SIZE], rvu); > + 
> On Wed, 4 Dec 2024 19:38:17 +0530 Sai Krishna wrote:
> > -	ret = request_irq(pci_irq_vector(rvu->pdev,
> RVU_AF_INT_VEC_MBOX),
> > -			  rvu_mbox_pf_intr_handler, 0,
> > -			  &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
> NAME_SIZE], rvu);
> > +	ret = request_irq(pci_irq_vector
> > +			  (rvu->pdev, RVU_AF_INT_VEC_MBOX),
> > +			  rvu->ng_rvu->rvu_mbox_ops->pf_intr_handler, 0,
> > +			  &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
> > +			  NAME_SIZE], rvu);
> 
> You're breaking these lines in very strange way. AFAICT they fit in
> 80 chars.

Ack, will submit V6 patch set with the suggested changes.

Thanks,
Sai