Re: [PATCH v3 7/8] arm64: dts: renesas: rzg3s-smarc: Enable SCIF3

[Geert Uytterhoeven]

Hi Claudiu,

On Fri, Nov 15, 2024 at 2:50 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Enable SCIF3. It is routed on the RZ SMARC Carrier II board on SER1_UART
> interface.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> @@ -9,9 +9,14 @@
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/pinctrl/rzg2l-pinctrl.h>
>
> +#include "rzg3s-smarc-switches.h"
> +
>  / {
>         aliases {
>                 i2c0 = &i2c0;
> +#if SW_CONFIG3 == SW_ON
> +               serial1 = &scif3;
> +#endif

According to my schematics, SCIF3 is routed unconditionally to
SER1_UART.

>                 serial3 = &scif0;
>                 mmc1 = &sdhi1;
>         };

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds