Re: [PATCH PATCH RFT 11/19] arm64: dts: qcom: sm8650: Fix CDSP memory length

[Krzysztof Kozlowski]

On 06/12/2024 16:42, Neil Armstrong wrote:
> On 06/12/2024 16:32, Krzysztof Kozlowski wrote:
>> The address space in CDSP PAS (Peripheral Authentication Service)
>> remoteproc node should point to the QDSP PUB address space
>> (QDSP6...SS_PUB) which has a length of 0x10000.  Value of 0x1400000 was
>> copied from older DTS, but it does not look accurate at all.
>>
>> This should have no functional impact on Linux users, because PAS loader
>> does not use this address space at all.
>>
>> Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes")
>> Cc: <stable@xxxxxxxxxxxxxxx>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> index 95ec82bce3162bce4a3da6122a41fee37118740e..1d935bcdcb2eee7b56e0a1f71c303a54d870e672 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> @@ -5481,7 +5481,7 @@ nsp_noc: interconnect@320c0000 {
>>   
>>   		remoteproc_cdsp: remoteproc@32300000 {
>>   			compatible = "qcom,sm8650-cdsp-pas";
>> -			reg = <0 0x32300000 0 0x1400000>;
>> +			reg = <0x0 0x32300000 0x0 0x10000>;
> 
> I tried to have an unified style in sm8650.dtsi by using 0 instead of 0x0,
> maybe you should keep the current style, as you prefer.

I got comment for sm8750 that preferred is 0x0, so above while touching
this. Also file already has inconsistencies - 0x0 mixed with 0.



Best regards,
Krzysztof