Re: drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c:173 mlx5_fc_stats_query_all_counters() error: uninitialized symbol 'bulk_query_time'.

[Dan Carpenter]

On Mon, Dec 09, 2024 at 10:09:59AM +0000, Cosmin Ratiu wrote:
> 
> Hi Dan,
> 
> Thanks for the report. But this came up during the submission and the
> conclusion was that this is a false positive from Smatch.
> See the discussions:
> https://lore.kernel.org/netdev/0dce2c1d2f8adccbfbff39118af9796d84404a67.camel@xxxxxxxxxx/
> https://lore.kernel.org/netdev/66ccbb841794c98b91d9e8aba48b90c63caa45e7.camel@xxxxxxxxxx/
> You were also part of that thread and you reported no issue on your
> side back then:
> https://lore.kernel.org/netdev/fcecb18a-1a30-400d-b8ec-1806d856d145@stanley.mountain/
> 
> I am not sure what the conclusion was on the Smatch side, whether there
> were planned fixes or the whole thing was just forgotten.

Ah, yes.  Thanks.  I have written a patch to silence this in Smatch, and
I'll test and push it later.

As a human reader it was the unlikely() annotation which confused me.

regards,
dan carpenter