Re: [PATCH v2] sched: deadline: Cleanup goto label in pick_earliest_pushable_dl_task

From: Juri Lelli
Date: Mon Dec 09 2024 - 06:44:39 EST


Hi John,

On 05/12/24 15:59, John Stultz wrote:
> Commit 8b5e770ed7c0 ("sched/deadline: Optimize pull_dl_task()")
> added a goto label seems would be better written as a while
> loop.
>
> So replace the goto with a while loop, to make it easier to read.
>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Juri Lelli <juri.lelli@xxxxxxxxxx>
> Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> Cc: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Ben Segall <bsegall@xxxxxxxxxx>
> Cc: Mel Gorman <mgorman@xxxxxxx>
> Cc: Valentin Schneider <vschneid@xxxxxxxxxx>
> Cc: Wanpeng Li <wanpeng.li@xxxxxxxxxxxxxxx>
> Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Cc: Todd Kjos <tkjos@xxxxxxxxxx>
> Cc: kernel-team@xxxxxxxxxxx
> Reported-by: Todd Kjos <tkjos@xxxxxxxxxx>
> Signed-off-by: John Stultz <jstultz@xxxxxxxxxx>

Acked-by: Juri Lelli <juri.lelli@xxxxxxxxxx>

Thanks!
Juri