Re: [PATCH] Grab mm lock before grabbing pt lock

[Maksym Planeta]

On 05/12/2024 19:52, Dave Hansen wrote:
> I have the _feeling_ it's just a big hack and this code throws caution
> tot the wind because of:
>
> >   * Expected to be called in stop_machine() ("equivalent to taking
> >   * every spinlock in the system"), so the locking doesn't really
> >   * matter all that much.
>
> So the patch here kinda doubles down on the hack and continues the theme
> because "locking doesn't really matter all that much."
>
> If so, it's not super satisfying, but it is consistent with the existing
> code.

I indeed could not find reasons why locking would be strictly necessary for correctness here. On the other hand a 
clearly benign warning should not be triggered, especially considering that panic_on_warn may be on on some systems.