Re: [PATCH v6 08/16] acpi/ghes: don't check if physical_address is not zero

From: Mauro Carvalho Chehab
Date: Mon Dec 09 2024 - 08:03:31 EST


Em Mon, 9 Dec 2024 11:36:40 +0000
Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> escreveu:

> On Sat, 7 Dec 2024 09:54:14 +0100
> Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:
>
> > The 'physical_address' value is a faulty page. As such, 0 is
> > as valid as any other value.
> Still not sure on what faulty pages are :)
>
> Given I tagged previous (after you'd sent this)
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

It seems I forgot adding this tag, from Igor's review, as per:
https://lore.kernel.org/qemu-devel/20241204141246.37a7cb9d@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
This patch was reviwed by Igor already, so:

Reviewed-by: Igor Mammedov <imammedo@xxxxxxxxxx>

>
> >
> > Suggested-by: Igor Mammedov <imammedo@xxxxxxxxxx>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > ---
> > hw/acpi/ghes.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
> > index edc74c38bf8a..a3dffd78b012 100644
> > --- a/hw/acpi/ghes.c
> > +++ b/hw/acpi/ghes.c
> > @@ -400,10 +400,6 @@ int acpi_ghes_record_errors(uint16_t source_id, uint64_t physical_address)
> >
> > start_addr = le64_to_cpu(ags->ghes_addr_le);
> >
> > - if (!physical_address) {
> > - return -1;
> > - }
> > -
> > start_addr += source_id * sizeof(uint64_t);
> >
> > cpu_physical_memory_read(start_addr, &error_block_addr,
>



Thanks,
Mauro