Re: [PATCH 0/5] x86/cpu: Remove duplicate microcode version matching infrastructure

From: Qiuxu Zhuo
Date: Mon Dec 09 2024 - 08:12:03 EST


Hi Dave,

> From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> [...]
> Changes from RFC:
> * Convert stepping match helpers to always take a range and never
> take a raw stepping bitmap. - Ingo
>
> --
>
> x86 has generic CPU matching infrastructure. This lets you build
> tables of CPUs with some property. It's mostly used for enumerating
> model-specific features, but it is quite a bit more flexible than
> that. In includes a facility to match steppings and microcode
> versions. This generic infrastructure is built around 'struct
> x86_cpu_id'.
>
> There is a less generic, parallel CPU matching facility built around
> 'struct x86_cpu_desc'. It is used only for matching specific microcode
> revisions. All of the 'struct x86_cpu_desc' users can be converted to
> 'struct x86_cpu_id'.
>
> Do that conversion then remove the 'struct x86_cpu_desc'
> infrastructure.
>
> Testing or acks would be much appreciated!

I tested this series + v6.13-rc2 on both Intel Cascade Lake server and Sapphire Rapids server.

- Both systems booted successfully.
- Both {skx,i10nm}_edac drivers[1][2] worked well.

[1] Covered patch2's drivers/edac/skx_base.c file.
[2] Covered patch2's drivers/edac/i10nm_base.c file.

Feel free to add:

Tested-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>