Re: [PATCH v2 0/2] arm64: dts: qcom: x1e80100: fix USB OTG regressions

From: Dmitry Baryshkov
Date: Mon Dec 09 2024 - 08:29:49 EST


On Mon, Dec 09, 2024 at 12:19:03PM +0100, Johan Hovold wrote:
> A recent change enabling OTG mode on the Lenovo ThinkPad T14s USB-C
> ports can break SuperSpeed device hotplugging.
>
> Abel noticed that the corresponding commit for the CRD also triggers a
> hard reset during resume from suspend.
>
> With retimer (and orientation detection) support not even merged yet,
> let's revert at least until we have stable host mode in mainline.
>
> Note that Stephan and Dmitry have already identified other problems with
> the offending commits here:
>
> https://lore.kernel.org/all/ZxZO6Prrm2ITUZMQ@xxxxxxxxxx/
> https://lore.kernel.org/all/hw2pdof4ajadjsjrb44f2q4cz4yh5qcqz5d3l7gjt2koycqs3k@xx5xvd26uyef
>
> Johan
>
>
> Changes in v2
> - revert also the corresponding patch for the CRD which breaks suspend

As you are reverting two commits, please revert the third one too, it
breaks pmic-glink.

>
>
> Johan Hovold (2):
> Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports"
> Revert "arm64: dts: qcom: x1e80100-crd: enable otg on usb ports"
>
> .../boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 8 ++++++++
> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 12 ++++++++++++
> 2 files changed, 20 insertions(+)
>
> --
> 2.45.2
>

--
With best wishes
Dmitry