Re: [PATCH v3 22/25] arm64: dts: renesas: rzg3s-smarc-som: Add versa3 clock generator node

[Geert Uytterhoeven]

On Wed, Nov 13, 2024 at 2:36 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Add versa3 clock generator node. It provides the clocks for the Ethernet
> PHY, PCIe, audio devices.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> @@ -152,6 +158,30 @@ &extal_clk {
>
>  &i2c1 {
>         status = "okay";
> +
> +       versa3: clock-generator@68 {

> +               renesas,settings = [
> +                 80 00 11 19 4c 42 dc 2f 06 7d 20 1a 5f 1e f2 27
> +                 00 40 00 00 00 00 00 00 06 0c 19 02 3f f0 90 86
> +                 a0 80 30 30 9c
> +               ];
> +       };
>  };

I did not verify renesas,settings. The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds