Re: [PATCH] wifi: wlcore: fix unbalanced pm_runtime calls

[Kalle Valo]

Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:

> If firmware boot failes, runtime pm is put too often:
> [12092.708099] wlcore: ERROR firmware boot failed despite 3 retries
> [12092.708099] wl18xx_driver wl18xx.1.auto: Runtime PM usage count underflow!
> Fix that by redirecting all error gotos before runtime_get so that runtime is not put.
> 
> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>

Do we know what commit broke this? A Fixes tag would be good to have.

Why not change this also to use out_unlock:

	role_type = wl12xx_get_role_type(wl, wlvif);
	if (role_type == WL12XX_INVALID_ROLE_TYPE) {
		ret = -EINVAL;
		goto out;
	}

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20241107181531.1774550-1-andreas@xxxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches