Re: [EXTERNAL] [PATCH] x86: Fix build regression with CONFIG_KEXEC_JUMP enabled

[David Woodhouse]

On Mon, 2024-12-09 at 17:22 +0100, Borislav Petkov wrote:
> On Mon, Dec 09, 2024 at 03:59:55PM +0000, David Woodhouse wrote:
> > (In fact, *lots* of the return path from kexec is just unreachable dead
> > code in the case that CONFIG_KEXEC_JUMP isn't set, but it seems we're
> > in the habit of #ifdeffing out only the parts that actually wouldn't
> > compile.)
> 
> Yeah, we're allergic to ugly ifdeffery.

I suspect it would be less ugly overall if we #ifdef out the whole of
the preserve_context code path when CONFIG_KEXEC_JUMP isn't enabled,
rather than only the various parts of it that actually cause compile
failures, leaving a very confusing set of nonsense dead code actually
being compiled in. But that's a potential cleanup for later; I'm
standing in a massive pile of yak hair already...

Attachment: smime.p7s
Description: S/MIME cryptographic signature