Re: [PATCH net-next 2/2] net: phy: microchip_t1: Autonegotiaion support for LAN887x T1 phy

[Andrew Lunn]

> -	/* First patch only supports 100Mbps and 1000Mbps force-mode.
> -	 * T1 Auto-Negotiation (Clause 98 of IEEE 802.3) will be added later.
> -	 */
> -	linkmode_clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->supported);
> -

What are the backwards compatibility issues here? I would at least
expect some comments in the commit message. As far as i understand, up
until this patch, it always required forced configuration. With this
patch, it suddenly will auto-neg by default? If the link partner is
not expecting auto-neg, that will fail.

> +/* LAN887X Errata: 100M master issue. Dual speed in Aneg is not supported. */

Please could you expand on this. We are now doing auto-neg by default,
and auto-neg is somewhat broken?

	Andrew