Re: [PATCH net v2] net: ethernet: 8390: Add HAS_IOPORT dependency for mcf8390

[Niklas Schnelle]

On Mon, 2024-12-09 at 12:26 +0100, Niklas Schnelle wrote:
> Since commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> for HAS_IOPORT=n") the I/O port accessors are compile-time optional. As
> m68k may or may not select HAS_IOPORT the COLDFIRE dependency is not
> enough to guarantee I/O port access. Add an explicit HAS_IOPORT
> dependency for mcf8390 to prevent a build failure as seen by the kernel
> test robot.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412080511.ORVinTDs-lkp@xxxxxxxxx/
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
> ---
> Changes in v2:
> - Add missing "net" prefix. Sorry about the noise
> - Link to v1: https://lore.kernel.org/r/20241209-mcf8390_has_ioport-v1-1-f263d573e243@xxxxxxxxxxxxx

See Arnd's answer[0] to v1 for why this patch may be fixing the compile
error but the code may already be broken independently.

[0]
https://lore.kernel.org/all/3ca55478-a5a9-442b-ae4f-a0a822f786d9@xxxxxxxxxxxxxxxx/