To me I politely disagree with the assessment made here, but if a senior
member of the kernel objects of course I'll withdraw it.
But yeah I don't think that's workable. We will just have to hope that we
notice mremap changes that might be problematic going forward, I might
therefore update my lei settings accordingly...
I have the feeling you take this personally; please don't.
Sure sorry it's text being a bad medium and this sort of thing _inevitably_
being a fraught subject :)
I have a great deal of respect for you so my imagining that you might think
I couldn't do things in this area was slightly shocking, but I suspect this
is, in fact, on reflection, not at all what you meant.
So sorry, I don't intend for this to be anything other than a functional
converastion to determine how best for us to manage workload and avoid
issues in future.
If you see my other mail with suggested ways forward, hopefully one of
those will help ensure appropriate separation and distribution of
workload/responsibility (am of course also open to whatever you might
suggest!)
Maybe my other mail with "VMA users" vs. "basic VMA functionality" makes it
clearer what I mean.
For example, mm/userfaultfd.c also performs VMA modifications. kernel/fork.c
does a bunch of that. I neither think these should go under VMA nor that it
should be split up.
Yeah and I _hate_ that. I mean talk to me about fs/userfaultfd.c, but maybe
only after a few pints :) Or bits of mm that live in fs, but vma-related
and not...
But these are areas to fix.
Maybe there is a better way to split up things or rework the code; likely
we'd want this code that works on VMAs to have a clean interface with the
core vma logic in vma.c, if the current way of handling it is a problem for
you.
I think we probably need a compromise for the time being, and as I was
saying to Jann I don't think it makes sense really to separate the VMA and
page table bits from these files _except_ when we finally have a shared
page table interface that we've spoken about before and perhaps we will
collaborate on in future :)
The key point is so we avoid stepping on landmines when we discover
something was merged in file X which we weren't cc'd on that breaks core
feature Y we have been working on in the VMA part of the code.