Re: [PATCH 2/2] soc: hisilicon: kunpeng_hbmcache: Add support for online and offline the hbm cache

From: Jeff Johnson
Date: Mon Dec 09 2024 - 19:01:32 EST


On 12/6/24 03:28, Zhang Zekun wrote:
> Add a driver for High Bandwidth Memory (HBM) cache, which provides user
> space interfaces to power on/off the HBM cache. Use HBM as a cache can
> take advantage of the high bandwidth of HBM in normal memory access, and
> OS does not need to aware of the existence of HBM cache. For workloads
> which does not require a high memory access bandwidth, power off the HBM
> cache device can help save energy.
>
> Signed-off-by: Zhang Zekun <zhangzekun11@xxxxxxxxxx>

...

> +module_exit(hbm_cache_module_exit);
> +MODULE_LICENSE("GPL");

Unlike the 1/2 patch, this one CAN be built as a module, so please add the
missing MODULE_DESCRIPTION() macro to avoid the warning with make W=1.

/jeff