Re: [PATCH] pm: cpupower: Makefile: Fix cross compilation

From: Shuah Khan
Date: Mon Dec 09 2024 - 19:59:01 EST


On 12/2/24 10:12, Florian Fainelli wrote:
On 11/28/24 17:20, Peng Fan (OSS) wrote:
From: Peng Fan <peng.fan@xxxxxxx>

After commit f79473ed9220 ("pm: cpupower: Makefile: Allow overriding
cross-compiling env params") we would fail to cross compile cpupower in
buildroot which uses the recipe at [1] where only the CROSS variable is
being set.

The issue here is the use of the lazy evaluation for all variables: CC,
LD, AR, STRIP, RANLIB, rather than just CROSS.

[1]:
https://git.buildroot.net/buildroot/tree/package/linux-tools/linux-tool-cpupower.mk.in

Fixes: f79473ed9220 ("pm: cpupower: Makefile: Allow overriding cross-compiling env params")
Reported-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
Closes: https://lore.kernel.org/all/2bbabd2c-24ef-493c-a199-594e5dada3da@xxxxxxxxxxxx/
Signed-off-by: Peng Fan <peng.fan@xxxxxxx>

Tested-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

Thanks!

Thank you. Applied to linux-cpupower for my next full request to
Rafael.

thanks,
-- Shuah