Re: [PATCH v7 3/3] crypto: Add Inside Secure SafeXcel EIP-93 crypto engine support

From: Herbert Xu
Date: Mon Dec 09 2024 - 22:23:55 EST


On Tue, Nov 12, 2024 at 02:59:00AM +0100, Christian Marangi wrote:
>
> +static int eip93_hash_export(struct ahash_request *req, void *out)
> +{
> + struct eip93_hash_reqctx *rctx = ahash_request_ctx(req);
> + struct eip93_hash_export_state *state = out;
> + DECLARE_CRYPTO_WAIT(wait);
> + int ret;
> +
> + crypto_init_wait(&wait);
> + /* Set the req callback for hash_partial_final wait */
> + ahash_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG,
> + crypto_req_done, &wait);
> +
> + /* Set for partial hash generation */
> + rctx->partial_hash = true;
> + rctx->export_state = true;
> + rctx->state = state;
> +
> + /* Save the first block in state data */
> + if (rctx->left_last || rctx->len) {
> + struct mkt_hash_block *block;
> +
> + block = list_first_entry(&rctx->blocks,
> + struct mkt_hash_block,
> + list);
> +
> + memcpy(state->data, block->data,
> + SHA256_BLOCK_SIZE - rctx->left_last);
> + }
> +
> + /* Call hash_partial_final.
> + * This will send a dummpy 0 length packet. This is done to
> + * wait for every descriptor to being handled and sync the sa_state
> + * from the host. Partial hash and any other data will be copied in
> + * eip93_hash_handle_result()
> + */
> + ret = crypto_wait_req(eip93_hash_partial_final(req), &wait);

Sorry, you can't do that here. Your hash state should have been
exported when the request previously completed. The export function
must not sleep.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt