RE: [PATCH net-next 1/2] net: phy: phy-c45: Auto-negotiaion changes for T1 phy in phy library

[Tarun.Alle]

Hi Andrew,

Thanks for your review comments.

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Monday, December 9, 2024 10:24 PM
> To: Tarun Alle - I68638 <Tarun.Alle@xxxxxxxxxxxxx>
> Cc: Arun Ramadoss - I17769 <Arun.Ramadoss@xxxxxxxxxxxxx>;
> UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>;
> hkallweit1@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next 1/2] net: phy: phy-c45: Auto-negotiaion
> changes for T1 phy in phy library
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> the content is safe
> 
> On Mon, Dec 09, 2024 at 09:44:26PM +0530, Tarun Alle wrote:
> > Below auto-negotiation library changes required for T1 phys:
> > - Lower byte advertisement register need to read after higher byte as
> >   per 802.3-2022 : Section 45.2.7.22.
> 
> Is this a fix? Does Linux have any T1 PHYs which already support auto-neg?
> Either add a comment this is not a fix because...., or please pull this out into
> a patch for net, with a Fixes: tag.
> 

There are few implementations for T1 PHY auto-neg. I will pull this out as a fix.

>         Andrew

Thanks,
Tarun Alle.