Re: [PATCH v5 5/9] memory: ti-aemif: Create aemif_set_cs_timings()

[Bastien Curutchet]

Hi Krzysztof,

On 12/9/24 8:41 PM, Krzysztof Kozlowski wrote:
> On 04/12/2024 10:43, Bastien Curutchet wrote:
> > Create an aemif_set_cs_timings() function to isolate the setting of a
> > chip select timing configuration and ease its exportation.
> >
> > Signed-off-by: Bastien Curutchet <bastien.curutchet@xxxxxxxxxxx>
> > Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > ---
> >   drivers/memory/ti-aemif.c | 65 +++++++++++++++++++++++++++++----------
> >   1 file changed, 49 insertions(+), 16 deletions(-)
>
> ...
>
> >   
> >   /**
> >    * struct aemif_cs_timings: structure to hold CS timings
> > @@ -165,6 +165,44 @@ static int aemif_check_cs_timings(struct aemif_cs_timings *timings)
> >   	return 0;
> >   }
> >   
> > +/**
> > + * aemif_set_cs_timings() - Set the timing configuration of a given chip select.
> > + * @aemif: aemif device to configure
> > + * @cs: index of the chip select to configure
> > + * @timings: timings configuration to set
> > + *
> > + * @return: 0 on success, else negative errno.
> > + */
> > +static int aemif_set_cs_timings(struct aemif_device *aemif, u8 cs, struct aemif_cs_timings *timings)
>
> In the future, please stick to 80-char wrapping unless exceeding makes
> code more readable (see Coding style). I fixed it up while applying.

Ok, thank you.


Best regards,
Bastien