Re: [PATCH] ASoC: amd: yc: Fix the wrong return value

[potturu venkata prasad]

On 12/10/24 12:58, Markus Elfring wrote:
> > > …
> > > > +++ b/sound/soc/amd/yc/acp6x-mach.c
> > > > @@ -578,14 +578,19 @@ static int acp6x_probe(struct platform_device *pdev)
> > > >
> > > >        handle = ACPI_HANDLE(pdev->dev.parent);
> > > >        ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
> > > > -    if (!ACPI_FAILURE(ret))
> > > > +    if (!ACPI_FAILURE(ret)) {
> > > >            wov_en = dmic_status;
> > > > +        if (!wov_en)
> > > > +            return -ENODEV;
> > > > +    } else {
> > > > +        /* Incase of ACPI method read failure then jump to check_dmi_entry */
> > > > +        goto check_dmi_entry;
> > > > +    }
> > > >
> > > >        if (is_dmic_enable && wov_en)
> > > >            platform_set_drvdata(pdev, &acp6x_card);
> > > …
> > >
> > > Is there a need to adjust another condition check accordingly?
> > No Markus, not required.
> Can it be that the expression part “&& wov_en” became redundant with the proposed
> source code adjustment?
Agreed, will remove && wov_en  and then send v2 patch.
> Regards,
> Markus