Re: [PATCH 2/3] kbuild: Drop support for include/asm-<arch> in headers_check.pl

From: Masahiro Yamada
Date: Tue Dec 10 2024 - 05:16:45 EST


I applied this with the follow-up squashed. Thanks.
(https://lore.kernel.org/all/CAK7LNAR8dy-=EcsZFb-tjXSk2sK7sHrV0WSSV4E8dzRh5Veceg@xxxxxxxxxxxxxx/T/#t)

This should be dropped from Andrew Morton's tree.




On Sat, Dec 7, 2024 at 11:27 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Thu, Dec 5, 2024 at 10:20 PM Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
> >
> > "include/asm-<arch>" was replaced by "arch/<arch>/include/asm" a long
> > time ago. All assembler header files are now included using
> > "#include <asm/*>", so there is no longer a need to rewrite paths.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
>
>
> After this commit, the second argument $arch is no longer
> used.
>
> Please clean up
>
> my ($dir, $arch, @files) = @ARGV;
>
>
>
>
>
>
>
> > usr/include/headers_check.pl | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/usr/include/headers_check.pl b/usr/include/headers_check.pl
> > index b6aec5e4365f9bf2..7070c891ea294b4d 100755
> > --- a/usr/include/headers_check.pl
> > +++ b/usr/include/headers_check.pl
> > @@ -54,10 +54,6 @@ sub check_include
> > my $inc = $1;
> > my $found;
> > $found = stat($dir . "/" . $inc);
> > - if (!$found) {
> > - $inc =~ s#asm/#asm-$arch/#;
> > - $found = stat($dir . "/" . $inc);
> > - }
> > if (!$found) {
> > printf STDERR "$filename:$lineno: included file '$inc' is not exported\n";
> > $ret = 1;
> > --
> > 2.34.1
> >
> >
>
>
> --
> Best Regards
> Masahiro Yamada



--
Best Regards
Masahiro Yamada