Re: [PATCH] extcon: Switch back to struct platform_driver::remove()
From: Uwe Kleine-König
Date: Tue Dec 10 2024 - 06:36:16 EST
Hello,
On Sun, Dec 08, 2024 at 09:49:16PM +0900, Chanwoo Choi wrote:
> On Wed, Nov 27, 2024 at 6:30 PM Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxx> wrote:
> > diff --git a/drivers/extcon/extcon-usbc-cros-ec.c b/drivers/extcon/extcon-usbc-cros-ec.c
> > index 805a47230689..529ac5898e38 100644
> > --- a/drivers/extcon/extcon-usbc-cros-ec.c
> > +++ b/drivers/extcon/extcon-usbc-cros-ec.c
> > @@ -525,12 +525,12 @@ MODULE_DEVICE_TABLE(of, extcon_cros_ec_of_match);
> >
> > static struct platform_driver extcon_cros_ec_driver = {
> > .driver = {
> > - .name = "extcon-usbc-cros-ec",
> > + .name = "extcon-usbc-cros-ec",
>
> If there is no change, this line is changed.
> Please don't touch this line.
I'm not 100% sure I understand what you say here. I guess you oppose to
fix the coding style as a side product of my patch.
Note that it's probably easiest to just not apply my patch as Linus
Torvalds fixed all .remove_new in his tree generating conflicts if
subsystems take similar patches.
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature