Re: [PATCH net-next v1 1/1] net: phy: Move callback comments from struct to kernel-doc section

[Mateusz Polchlopek]

On 12/6/2024 12:39 PM, Oleksij Rempel wrote:
> Relocate all callback-related comments from the `struct phy_driver`
> definition to a dedicated `kernel-doc` section. This improves code
> readability by decluttering the structure definition and consolidating
> callback documentation in a central place for kernel-doc generation.
>
> No functional changes are introduced by this patch.
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
>   include/linux/phy.h | 705 ++++++++++++++++++++++++++++++++------------
>   1 file changed, 522 insertions(+), 183 deletions(-)

[...]

Nice cleanup! The only nitpick is about the "Returns" statement in
functions. According to the kdoc it should be "Return:" . But
nevertheless it looks good, so:

Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@xxxxxxxxx>