Re: [PATCH v7 14/28] media: iris: implement iris v4l2_ctrl_ops

[Stefan Schmidt]

Hello Dikshita,

On Mon, 9 Dec 2024 at 13:57, Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> wrote:

> +static struct platform_inst_fw_cap inst_fw_cap_sm8550[] = {
> +       {
> +               .cap_id = PROFILE,
> +               .min = V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE,
> +               .max = V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_HIGH,
> +               .step_or_mask = BIT(V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_HIGH) |

Would it make sense to have
V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_HIGH as the maximum as last
item here?
You have this sorting in the LEVEL list below and even here in the
profiles only CONSTRAINED_HIGH is out of order.
I realise this is technically not needed, but I had to go and look it
up in the v4l2 enum to check if CONSTRAINED_HIGH is really bigger than
HIGH and should be listed as .max.

> +                               BIT(V4L2_MPEG_VIDEO_H264_PROFILE_CONSTRAINED_BASELINE) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_PROFILE_HIGH),
> +               .value = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
> +               .hfi_id = HFI_PROP_PROFILE,
> +               .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
> +       },
> +       {
> +               .cap_id = LEVEL,
> +               .min = V4L2_MPEG_VIDEO_H264_LEVEL_1_0,
> +               .max = V4L2_MPEG_VIDEO_H264_LEVEL_6_2,
> +               .step_or_mask = BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1_0) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1B) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1_1) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1_2) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_1_3) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_2_0) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_2_1) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_2_2) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_3_0) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_3_1) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_3_2) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_4_0) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_4_1) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_4_2) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_5_0) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_5_1) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_5_2) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_6_0) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_6_1) |
> +                               BIT(V4L2_MPEG_VIDEO_H264_LEVEL_6_2),
> +               .value = V4L2_MPEG_VIDEO_H264_LEVEL_6_1,
> +               .hfi_id = HFI_PROP_LEVEL,
> +               .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU,
> +       },

regards
Stefan Schmidt