Re: [PATCH 0/3] sunrpc: Deadcoding
From: Jeff Layton
Date: Tue Dec 10 2024 - 07:26:31 EST
On Tue, 2024-12-10 at 01:02 +0000, linux@xxxxxxxxxxx wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> Hi,
> This is a bunch of deadcoding around the sunrpc code.
> This all removes whole functions/definitions/files
> rather than changing any actual codepaths.
>
> Dave
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
>
> Dr. David Alan Gilbert (3):
> sunrpc: Remove unused xprt_iter_get_xprt
> sunrpc: Remove gss_generic_token deadcode
> sunrpc: Remove gss_{de,en}crypt_xdr_buf deadcode
>
> include/linux/sunrpc/gss_asn1.h | 81 ---------
> include/linux/sunrpc/gss_krb5.h | 1 -
> include/linux/sunrpc/xprtmultipath.h | 1 -
> net/sunrpc/auth_gss/Makefile | 2 +-
> net/sunrpc/auth_gss/gss_generic_token.c | 231 ------------------------
> net/sunrpc/auth_gss/gss_krb5_crypto.c | 55 ------
> net/sunrpc/auth_gss/gss_krb5_internal.h | 7 -
> net/sunrpc/auth_gss/gss_mech_switch.c | 1 -
> net/sunrpc/xprtmultipath.c | 17 --
> 9 files changed, 1 insertion(+), 395 deletions(-)
> delete mode 100644 include/linux/sunrpc/gss_asn1.h
> delete mode 100644 net/sunrpc/auth_gss/gss_generic_token.c
>
I love removing unused code. Assuming everything builds OK after this:
Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>