Re: [PATCH v3 0/3] drm/rockchip: Add driver for the new DSI2 controller

[Heiko Stübner]

Hi Andy,

Am Dienstag, 10. Dezember 2024, 13:48:12 CET schrieb Andy Yan:
> 在 2024-12-10 20:32:03，"Dmitry Baryshkov" <dmitry.baryshkov@xxxxxxxxxx> 写道：
> >On Tue, Dec 10, 2024 at 09:54:09AM +0800, Andy Yan wrote:
> >> 在 2024-12-10 09:45:11，"Dmitry Baryshkov" <dmitry.baryshkov@xxxxxxxxxx> 写道：
> >> >On Tue, 10 Dec 2024 at 03:22, Andy Yan <andyshrk@xxxxxxx> wrote:
> >> >> 在 2024-12-10 09:01:38，"Dmitry Baryshkov" <dmitry.baryshkov@xxxxxxxxxx> 写道：
> >> >> >On Tue, Dec 10, 2024 at 08:50:51AM +0800, Andy Yan wrote:
> >> >> >> At 2024-12-10 07:12:26, "Heiko Stübner" <heiko@xxxxxxxxx> wrote:
> >> >> >> >Am Montag, 9. Dezember 2024, 17:11:03 CET schrieb Diederik de Haas:
> >> >> >> >> On Mon Dec 9, 2024 at 4:06 PM CET, Daniel Semkowicz wrote:
> >> >> >> >> > On 03.12.24 21:54, Heiko Stuebner wrote:
> >> >> >> >This really sounds like something is wrong on the vop side.
> >> >> >> >The interrupt is part of the vop, the divisable by 4 things likely too.
> >> >> >>
> >> >> >> This is a hardware limitation on vop side:
> >> >> >> The horizontal resolution must be 4 pixel aligned.
> >> >> >
> >> >> >Then mode_valid() and atomic_check() must reject modes that don't fit.
> >> >>
> >> >> We round down to 4 pixel aligned in mode_fixup in our bsp kernel,
> >> >
> >> >What is meant by the "bsp kernel" here? I don't see it being present
> >> 
> >> bsp kernel means downstream vendor kernel.
> >> 
> >> >in the mainline kernel. So, if the mode is unsupported, it should be
> >> 
> >> Will it be acceptable to add this round down in the mainline mode_fixup?
> >
> >I think so.
> 
> Then I can write a patch for it.

thanks a lot for looking into that :-)


Heiko