Re: [PATCH v4 1/2] can: m_can: set init flag earlier in probe

From: Marc Kleine-Budde
Date: Tue Dec 10 2024 - 09:38:11 EST


On 07.10.2024 10:23:58, Matthias Schiffer wrote:
> While an m_can controller usually already has the init flag from a
> hardware reset, no such reset happens on the integrated m_can_pci of the
> Intel Elkhart Lake. If the CAN controller is found in an active state,
> m_can_dev_setup() would fail because m_can_niso_supported() calls
> m_can_cccr_update_bits(), which refuses to modify any other configuration
> bits when CCCR_INIT is not set.
>
> To avoid this issue, set CCCR_INIT before attempting to modify any other
> configuration flags.
>
> Fixes: cd5a46ce6fa6 ("can: m_can: don't enable transceiver when probing")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxxxxx>
> Reviewed-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>

Applied to linux-can.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature