Re: [PATCH v2 14/15] arm64: dts: renesas: r9a08g045: Add USB support

[Geert Uytterhoeven]

Hi Claudiu,

On Tue, Nov 26, 2024 at 10:21 AM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Add USB nodes for the Renesas RZ/G3S SoC. This consists of PHY reset,
> host and device support.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> ---
>
> Changes in v2:
> - this was patch 14/16 in v1
> - added renesas,sysc-signal properties to USB PHYs
> - collected tags
> - Geert: I kept your tag; please let me know if you consider otherwise

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a08g045.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a08g045.dtsi
> @@ -417,6 +417,125 @@ eth1: ethernet@11c40000 {
>                         status = "disabled";
>                 };
>
> +               phyrst: usbphy-ctrl@11e00000 {
[...]
> +               ohci0: usb@11e10000 {
[...]
> +               ehci0: usb@11e10100 {
[...]
> +               usb2_phy0: usb-phy@11e10200 {
[...]
> +               hsusb: usb@11e20000 {
[...]
> +               ohci1: usb@11e30000 {
[...]
> +               ehci1: usb@11e30100 {
[...]
> +               usb2_phy1: usb-phy@11e30200 {

Please keep similar nodes together, i.e.

    phyrst: usbphy-ctrl@11e00000 {
    ohci0: usb@11e10000 {
    ohci1: usb@11e30000 {
    ehci0: usb@11e10100 {
    ehci1: usb@11e30100 {
    usb2_phy0: usb-phy@11e10200 {
    usb2_phy1: usb-phy@11e30200 {
    hsusb: usb@11e20000 {

After that, you can easily compare with similar SoCs:

    soc-dts-diff arch/arm64/boot/dts/renesas/r9a0{7g044,8g045}.dtsi

https://github.com/geertu/linux-scripts/blob/master/soc-dts-diff

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds