Re: [PATCH v2 01/11] x86/Kconfig: Geode CPU has cmpxchg8b

From: Brian Gerst
Date: Tue Dec 10 2024 - 11:01:02 EST


On Tue, Dec 10, 2024 at 9:50 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> An older cleanup of mine inadvertently removed geode-gx1 and geode-lx
> from the list of CPUs that are known to support a working cmpxchg8b.
>
> Fixes: 88a2b4edda3d ("x86/Kconfig: Rework CONFIG_X86_PAE dependency")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> arch/x86/Kconfig.cpu | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
> index 2a7279d80460..42e6a40876ea 100644
> --- a/arch/x86/Kconfig.cpu
> +++ b/arch/x86/Kconfig.cpu
> @@ -368,7 +368,7 @@ config X86_HAVE_PAE
>
> config X86_CMPXCHG64
> def_bool y
> - depends on X86_HAVE_PAE || M586TSC || M586MMX || MK6 || MK7
> + depends on X86_HAVE_PAE || M586TSC || M586MMX || MK6 || MK7 || MGEODEGX1 || MGEODE_LX
>
> # this should be set for all -march=.. options where the compiler
> # generates cmov.
> --
> 2.39.5
>
>

An idea for a future cleanup would be to change lists like this to
select statements. That would make it easier to see what each CPU
option enables.


Brian Gerst