Re: [patch 1/5] ARC: Remove GENERIC_PENDING_IRQ

From: Vineet Gupta
Date: Tue Dec 10 2024 - 12:22:16 EST


On 12/10/24 02:34, Thomas Gleixner wrote:
> Nothing uses the actual functionality and the MCIP controller sets the
> flags which disables the deferred affinity change. The other interrupt
> controller does not support affinity setting at all.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Vineet Gupta <vgupta@xxxxxxxxxx>

Acked-by: Vineet Gupta <vgupta@xxxxxxxxxx>   # arch/arc/

> ---
> arch/arc/Kconfig | 1 -
> arch/arc/kernel/mcip.c | 2 --
> kernel/irq/debugfs.c | 1 +
> 3 files changed, 1 insertion(+), 3 deletions(-)
>
> --- a/arch/arc/Kconfig
> +++ b/arch/arc/Kconfig
> @@ -24,7 +24,6 @@ config ARC
> # for now, we don't need GENERIC_IRQ_PROBE, CONFIG_GENERIC_IRQ_CHIP
> select GENERIC_IRQ_SHOW
> select GENERIC_PCI_IOMAP
> - select GENERIC_PENDING_IRQ if SMP
> select GENERIC_SCHED_CLOCK
> select GENERIC_SMP_IDLE_THREAD
> select GENERIC_IOREMAP
> --- a/arch/arc/kernel/mcip.c
> +++ b/arch/arc/kernel/mcip.c
> @@ -357,8 +357,6 @@ static void idu_cascade_isr(struct irq_d
> static int idu_irq_map(struct irq_domain *d, unsigned int virq, irq_hw_number_t hwirq)
> {
> irq_set_chip_and_handler(virq, &idu_irq_chip, handle_level_irq);
> - irq_set_status_flags(virq, IRQ_MOVE_PCNTXT);
> -
> return 0;
> }
>
> --- a/kernel/irq/debugfs.c
> +++ b/kernel/irq/debugfs.c
> @@ -53,6 +53,7 @@ static const struct irq_bit_descr irqchi
> BIT_MASK_DESCR(IRQCHIP_SUPPORTS_NMI),
> BIT_MASK_DESCR(IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND),
> BIT_MASK_DESCR(IRQCHIP_IMMUTABLE),
> + BIT_MASK_DESCR(IRQCHIP_MOVE_DEFERRED),

I think this leaked in here, needs to be in patch 3/5

Cheers,
-Vineet

> };
>
> static void
>