Re: [PATCH] ACPICA: events/evxfregn: don't release the ContextMutex that was never acquired

[Rafael J. Wysocki]

On Fri, Nov 22, 2024 at 9:30 AM Daniil Tatianin
<d-tatianin@xxxxxxxxxxxxxx> wrote:
>
> This bug was first introduced in c27f3d011b08, where the author of the
> patch probably meant to do DeleteMutex instead of ReleaseMutex. The
> mutex leak was noticed later on and fixed in e4dfe108371, but the bogus
> MutexRelease line was never removed, so do it now.
>
> Link: https://github.com/acpica/acpica/pull/982
> Fixes: c27f3d011b08 ("Fix race in GenericSerialBus (I2C) and GPIO OpRegion parameter handling")
> Signed-off-by: Daniil Tatianin <d-tatianin@xxxxxxxxxxxxxx>
> ---
>  drivers/acpi/acpica/evxfregn.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/evxfregn.c b/drivers/acpi/acpica/evxfregn.c
> index 95f78383bbdb..bff2d099f469 100644
> --- a/drivers/acpi/acpica/evxfregn.c
> +++ b/drivers/acpi/acpica/evxfregn.c
> @@ -232,8 +232,6 @@ acpi_remove_address_space_handler(acpi_handle device,
>
>                         /* Now we can delete the handler object */
>
> -                       acpi_os_release_mutex(handler_obj->address_space.
> -                                             context_mutex);
>                         acpi_ut_remove_reference(handler_obj);
>                         goto unlock_and_exit;
>                 }
> --

Applied as 6.13-rc material, thanks!