Re: [PATCH v7 3/3] crypto: Add Inside Secure SafeXcel EIP-93 crypto engine support
From: Christian Marangi
Date: Tue Dec 10 2024 - 15:52:04 EST
On Tue, Dec 10, 2024 at 09:27:53PM +0800, Herbert Xu wrote:
> On Tue, Dec 10, 2024 at 01:16:42PM +0100, Christian Marangi wrote:
> >
> > Oh! Ok, that is neat. Just to make sure everything is clear,
> > to complete the request it's the same used for final, the
> > ahash_request_complete(). I tought the -EINPROGRESS,
> > ahash_request_complete() pattern was only for final.
>
> Correct, the same calling convention applies whether you're doing
> update or finup/final. One difference is that after final/finup
> you don't have to export the hash state because it's no longer
> defined.
>
I just sent v8 with the thing fixed. Hope everything is good now!
As always I passed it with the test flag enabled + extra and fuzz set to
10000.
--
Ansuel