Re: [PATCH 1/4] x86/smp: Explicitly include <linux/thread_info.h>

From: Borislav Petkov
Date: Tue Dec 10 2024 - 16:36:57 EST


On Tue, Dec 10, 2024 at 06:46:07PM +0000, Kevin Brodsky wrote:
> diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
> index ca073f40698f..88e72b414bfa 100644
> --- a/arch/x86/include/asm/smp.h
> +++ b/arch/x86/include/asm/smp.h
> @@ -6,7 +6,7 @@
>
> #include <asm/cpumask.h>
> #include <asm/current.h>
> -#include <asm/thread_info.h>
> +#include <linux/thread_info.h>

linux/ namespace headers come before asm/ ones, I'd say.

But, more importantly, why is this 4 patches instead of 2:

1. Remove unused __set_memory_prot
2. Fixup include hell

?

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette