Re: [PATCH net-next v5] net: dlink: add support for reporting stats via `ethtool -S` and `ip -s -s link show`
From: Jakub Kicinski
Date: Tue Dec 10 2024 - 22:15:26 EST
On Mon, 9 Dec 2024 18:28:27 +0900 Moon Yeounsu wrote:
> + unsigned long flags;
> +
> + spin_lock_irqsave(&np->stats_lock, flags);
I believe spin_lock_bh() is sufficient here, no need to save IRQ flags.
> + u64 collisions = np->single_collisions + np->multi_collisions;
> + u64 tx_frames_abort = np->tx_frames_abort;
> + u64 tx_carrier_errors = np->tx_carrier_sense_errors;
Please don't mix code and variable declarations.
--
pw-bot: cr