Re: [PATCH v6 01/11] kconfig: Add PicoSAT interface

[Luis Chamberlain]

On Mon, Dec 09, 2024 at 01:57:13AM +0100, Ole Schuerks wrote:
> Thanks for all the feedback.
> 
> > This just deals with the first error and there is no unwinding, is that OK?
> 
> This should be OK. dlsym() only retrieves the address of a symbol from an
> already loaded object. The calls to dlsym() thus should not need to be
> unwound, it's sufficient to unload the object via dlclose().

OK thanks, maybe add a comment about it.

> > Other than that, did you run this through checkpatch.pl?
> 
> I ran all patches through checkpath.pl. The only reported issues with this
> patch are the ones related to the use of the X-macro and one about the
> typedef for the PicoSAT type. 

I don't know what x-macro is so I don't have any clear opinion on that.

  Luis